LibCore: Explicitly export symbols in LibCore #7011
+160
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Goc
force-pushed
the
export-core
branch
6 times, most recently
from
1b43eea to
bbbad61
Compare
This patch enables explicit symbol export for LibCoreMinimal.
R-Goc
force-pushed
the
export-core
branch
2 times, most recently
from
d6f8c7d to
07c6c80
Compare
R-Goc
changed the title
This patch adds explicit symbol export to LibCore. This leads to about 300 less symbols being exported.
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables explicit symbol export for LibCoreMinimal and LibCore. This reduces the number of symbols in LibCoreMinimal from ~800 to under 150, and in LibCore from ~500 to ~200.