Skip to content

LibWeb: dont inject natural sizes from prepare_for_replaced_layout #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jonbgamble wants to merge 11 commits into
base: master
Choose a base branch
from
Open

LibWeb: dont inject natural sizes from prepare_for_replaced_layout #7028

jonbgamble wants to merge 11 commits into from

Conversation

@jonbgamble
Copy link

@jonbgamble jonbgamble commented Dec 5, 2025 •
edited
Loading

Instead, compute them in accessors.

Add TextAreaBox and TextInputBox to Layout so that textarea and text inputs can be stretched when auto.

Fix #634, fix #6040, fix #7070, and possibly related issues involving baseline, cross axis sizing, aspect ratio, canvas, size containment, and textarea

@ladybird-bot
Copy link
Collaborator

ladybird-bot commented Dec 5, 2025

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@jonbgamble jonbgamble changed the title LibWeb: dont inject replaced sizes from Layout::X constructors LibWeb: dont inject replaced sizes from Layout constructors Dec 5, 2025
@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch 2 times, most recently from 720f705 to 84abc88 Compare December 5, 2025 05:01
@jonbgamble jonbgamble changed the title LibWeb: dont inject replaced sizes from Layout constructors LibWeb: dont inject Layout sizes from constructors or prepare methods Dec 5, 2025
@jonbgamble jonbgamble changed the title LibWeb: dont inject Layout sizes from constructors or prepare methods LibWeb: dont inject natural sizes from prepare_for_replaced_layout Dec 5, 2025
@jonbgamble jonbgamble marked this pull request as draft December 6, 2025 17:21
@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch 3 times, most recently from c25e0ee to f36a1fc Compare December 7, 2025 15:43
@jonbgamble jonbgamble marked this pull request as ready for review December 7, 2025 15:45
@jonbgamble jonbgamble requested a review from AtkinsSJ as a code owner December 7, 2025 17:15
@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch from 5520ff6 to 2e9c8cb Compare December 8, 2025 15:42
@github-actions github-actions bot removed the conflicts Pull request has merge conflicts that need resolution label Dec 8, 2025
@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch 2 times, most recently from 43f93ae to 0f8b840 Compare December 9, 2025 06:13
@Gingeh
Copy link
Contributor

Gingeh commented Dec 9, 2025

I can't comment on the implementation itself, but this patch fixes the page I opened #6040 for

@gmta
Copy link
Collaborator

gmta commented Dec 9, 2025

Hi! Please check our contribution guidelines, and particularly:

Split your changes into separate, atomic commits (i.e. A commit per feature or fix, where the build, tests and the system are all functioning).

Basically, whenever your commit message starts to describe more than one thing, it's very likely that we'd like to see separate commits. You should split them up to discern between non-functional changes involving code cleanup, refactors to prepare for changes, bugfixes and functional changes.

@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch 2 times, most recently from a4be658 to 76cefaa Compare December 10, 2025 00:35
@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch 3 times, most recently from 7b28372 to 572d31e Compare December 10, 2025 00:56
@jonbgamble
LibWeb: Use SizeWithAspectRatio struct
bc1e33a
@jonbgamble
LibWeb/Layout: Rename cached_intrinsic_sizes to intrinsic_min_max_cache
37a5c86
@jonbgamble
LibWeb/Layout: Add Box::intrinsic_context_box_size
c968ce6
@jonbgamble
LibWeb/Layout: Lazy compute rather than inject natural sizes
4631c7f 
Ditch prepare_for_replaced_layout size value injection in favor of
virtual accessors that compute the same. This affects ReplacedBox
and all its subclasses.

Distinguish between:
  - Natural size - always from media sources
  - Intrinsic content box size (i.e. replaced-like) - could be natural
    size or could be calculated from attributes like size, rows, cols
@jonbgamble
LibWeb/Layout: Honor definite cross sizes in flex layouts
c395334 
Don't overwrite them with aspect ratio calculations.
@jonbgamble
LibWeb/Layout: Fix box_baseline for multiple linebox rows
2545d39
@jonbgamble
LibWeb: Add TextAreaBox for textarea formatting
21ffafe 
The is_textarea_box() flag in Node.h is unfortunate, but it's
marginally better than an include & cast. textarea has specific
baseline handling compared to other inline-block elements.
@jonbgamble
LibWeb/Layout: Add TextInputBox for layout flexibility
4b7515d
@jonbgamble
LibWeb: Update layout tests
16f5830
@jonbgamble jonbgamble force-pushed the libweb-lazy-replaced-sizing branch from 572d31e to 16f5830 Compare December 10, 2025 01:00
@jonbgamble
Copy link
Author

jonbgamble commented Dec 10, 2025

I will say this about your commit message linter - I have had more enjoyable interactions with the rust borrow checker.

@gmta
Copy link
Collaborator

gmta commented Dec 10, 2025

@jonbgamble

I will say this about your commit message linter - I have had more enjoyable interactions with the rust borrow checker.

Did you use pre-commit locally to lint your commits before pushing?

If there's anything in particular that we should improve with the commit linter, feel free to raise an issue or submit a PR.

@jonbgamble
Copy link
Author

jonbgamble commented Dec 10, 2025

Did you use pre-commit locally to lint your commits before pushing?

I did not, and thanks for the heads up about it. I am just now remembering to run lint-clang-format.py

If there's anything in particular that we should improve with the commit linter, feel free to raise an issue or submit a PR.

Oh, it was just frustration from trying to force push a bunch of pseudo-historical commits carefully constructed from manual edits of git add -p hunks, only to be told "such and such commit message first line ends with a period" or "commit message isn't capital after the colon".

I'm miles away from an actionable suggestion.

circl-lastname
circl-lastname reviewed Dec 12, 2025
View reviewed changes
Libraries/LibWeb/Layout/TextAreaBox.cpp Outdated
@@ -0,0 +1,25 @@
/*
* Copyright (c) 2018-2025, Andreas Kling <[email protected]>
Copy link
Contributor

@circl-lastname circl-lastname Dec 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably credit new files to yourself, starting in 2025 (unless this new file is a result of splitting an old one)

Copy link
Author

@jonbgamble jonbgamble Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some kind of modification threshold for attribution of changes to an existing file (i.e. when you should add your name to the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AtkinsSJ AtkinsSJ Awaiting requested review from AtkinsSJ AtkinsSJ is a code owner

@alimpfard alimpfard Awaiting requested review from alimpfard

1 more reviewer

@circl-lastname circl-lastname circl-lastname left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@jonbgamble @ladybird-bot @Gingeh @gmta @circl-lastname