Fix bind mount unmount breaking host /dev/pts #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
MNT_DETACH(lazy unmount) on bind-mounted pseudo-filesystems like/dev/ptsleaves the host in a broken state where PTY allocation fails (sudo: unable to allocate pty: No such device).Changes
umount2(flags=0)first, fall back toMNT_DETACHonly onEBUSYraw_os_error()results to avoid redundant calls, properly distinguishEINVAL/ENOENT/EBUSYBefore:
After:
This prevents host filesystem corruption while maintaining backward compatibility for busy mounts.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.