Skip to content

Feat/search currency#8

Open
Otagera wants to merge 5 commits intoLaniJ:masterfrom
Otagera:feat/search-currency
Open

Feat/search currency#8
Otagera wants to merge 5 commits intoLaniJ:masterfrom
Otagera:feat/search-currency

Conversation

@Otagera
Copy link
Copy Markdown

@Otagera Otagera commented Jul 28, 2023

I just added the simple feature of searching for a particular currency based on the country with autocomplete added to it.
So the changes I made

  • src/components/Dropdown/Dropdown.jsx
  • src/components/Dropdown/SearchDropdown.jsx
  • src/components/Dropdown/dropdown.module.scss
  • src/data/currencies.json
  • src/lib/trie.js

So the final thing would look like this ->
Screenshot 2023-07-28 at 09 08 53

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
invoice-receipt-generator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 1:58pm

@Otagera
Copy link
Copy Markdown
Author

Otagera commented Jul 28, 2023

This is the relevant issue #7

@LaniJ
Copy link
Copy Markdown
Owner

LaniJ commented Aug 6, 2023

Hi @Otagera

Thanks so much for contributing!
I have some feedbacks.
So when I tested, I noticed that it doesn’t work when I press enter. Is there something I’m missing?
Also, as it is a currency dropdown, I think it would be better if the search is done by currency as opposed to searching by country name.

@Otagera
Copy link
Copy Markdown
Author

Otagera commented Aug 6, 2023

Hi @LaniJ
Thanks for the feedback

  1. Concerning enter, if you use the right arrow-key it auto completes I will change it to enter.
  2. Concerning searching by currency, I choose country because I though that would be easier, but I will see if the currency is doable.

@LaniJ
Copy link
Copy Markdown
Owner

LaniJ commented Aug 6, 2023

yeah. you're correct, the auto complete works fine, but it didn't select the currency when I tested it.

@Otagera
Copy link
Copy Markdown
Author

Otagera commented Aug 7, 2023

Hi @LaniJ,
I've fixed the issue with enter to select the currency and I added a new placeholder so it's clear you are searching by country

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants