Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parameters with github lfs #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

317070
Copy link

@317070 317070 commented Dec 1, 2015

I have added the parameters into a Lasagne readable format for vgg-16, vgg-19 and googlenet. These parameters are stored on git large file storage: https://git-lfs.github.com/
The result of these networks are equal except for floating point rounding with the original caffe models.

@ebenolson
Copy link
Member

Thanks, but as I mentioned in #4, I don't think Github LFS is a great fit for this - their free tier quota is quite limited and already exceeded by this PR...

Since these model definitions have been available for a while and are used/copied in several of the example notebooks, I'd rather not change them without a strong reason. I also personally prefer the compactness of the current format, and would like to avoid a dependency on pycaffe.

@f0k
Copy link
Member

f0k commented Dec 3, 2015

I'd rather not change them without a strong reason.

+1, there might even be users relying on the current interface (i.e., being able to import the file and calling build_model()). If we're changing the files, the interface should remain compatible.

I also personally prefer the compactness of the current format,

+1! Yours are a lot easier to read.

and would like to avoid a dependency on pycaffe.

+1. Note that https://github.com/Lasagne/Recipes/blob/master/examples/Using%20a%20Caffe%20Pretrained%20Network%20-%20CIFAR10.ipynb already shows how to get a Caffe model into Lasagne, so there's no reason to replicate it in modelzoo/googlenet.py. It would be nice to have a general converter script in modelzoo/, though, as that's where people would look for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants