add method to set default kind of new variables in VarStore #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of
VarStore::set_kind
to change the default kind for all new variables created in theVarStore
, similar totorch.set_default_dtype
(but localized to theVarStore
).The need for this is that for larger models like Llama-7b first instantiating an empty model and then filling in the tensors from an mmap-ed safetenstors file (for example) won't work on a 24GB GPU since a 7B won't fit in
Kind::Float
. Rather, newly inited tensors need to start out asKind::Half
orKind::BFloat16
.The default behavior of
VarStore
is unchanged -- existing code that doesn't callset_kind
will have new tensors created at asKind::Float
.