Fix glog for pytorch 2.3.x branch. #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-vri-es
force-pushed
the
fix-glog-pytorch-2.3.0
branch
from
7cf1cb6
to
a9b1e01
Compare
LaurentMazare
merged commit 155735a
into
LaurentMazare:torch-2.3.0
10 of 13 checks passed
|
Merged, I've published some minor update to the 0.16 release based on your branch so hopefully you can just use them now, e.g. https://crates.io/crates/tch/0.16.1 |
|
Awesome! Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly I can't update to pytorch 2.4.0 yet, but glog is already broken (same problem as #852).
So I would be very happy if we can backport this to the 2.3.0 branch and have a release so I can get back to using a semver dependency <3