Support Retrieving Named Attributes #913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this library supported getting a list of named tensors from a module. However, modules may also have attributes to store additional metadata. This commit adds support for getting them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this library supported getting a list of named tensors from a module. However, modules may also have attributes to store additional metadata. This commit adds support for getting them.
As for implementation, this commit follows the same strategy as retrieving named parameters, and it adds two smoke tests to check functionality. Notably, this commit is tested with LibTorch 2.5.0 instead of 2.5.1, and
LIBTORCH_BYPASS_VERSION_CHECKis set.