-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove dead code #1206
Open
0xClandestine
wants to merge
2
commits into
dev
Choose a base branch
from
refactor/remove-dead-code
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of this shouldn't be removed, this branch is mostly meant to illustrate what's currently dead. |
804cd7c
to
602cf38
Compare
wadealexc
requested changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files that we should NOT tweak:
script/releases/Env.sol
- This library interacts with Zeus ENV variables, so anytime we have release scripts that aren't using some ENV variables, the methods that fetch those will be "dead". Let's not remove this code; we'll want it when writing future release scripts.
src/contracts/libraries/BytesLib.sol
- This isn't our code, it's a common library written by Goncalo Sa. Let's not alter the code; it's easier to validate that it's the "standard version" if we keep it as-is.
- Anything in
test/integration/deprecatedInterfaces
- It's dead now, but if we decide we need it, it's much more of a pain in the ass to re-implement/lookup old interfaces
- Removed changes to Env.sol, BytesLib.sol, and deprecated interfaces.
b9eb2da
to
3e6d244
Compare
0xClandestine
commented
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
♻️ Refactor
Code improvements without changing functionality.
📜 Script
Script-related changes (automation, tooling).
🧪 Test
Test-related changes (unit, integration, etc.).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We've got dead code throughout the repo.
Modifications:
Result:
Dead code has been removed.