-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add operator set support for ECDSA stake registry #411
Open
jaxxjj
wants to merge
16
commits into
Layr-Labs:dev
Choose a base branch
from
jaxxjj:jaxxjj/ecdsa-stake-registry
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jj/eigenlayer-middleware into jaxxjj/ecdsa-stake-registry
gm @stevennevins I've already updated the tests - could you please review them when you have a chance? |
…jj/eigenlayer-middleware into jaxxjj/ecdsa-stake-registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With the slashing release upcoming, the current ECDSAStakeRegistry has not yet been updated to support operator sets. The system currently only supports M2 quorum registration, creating a need for a more flexible and comprehensive registration mechanism while maintaining backward compatibility.
Modifications:
ECDSAStakeRegistry
registerOperatorWithSignature
→registerOperatorM2Quorum
deregisterOperator
→deregisterOperatorM2Quorum
onOperatorSetRegistered
- handles AllocationManager registrationonOperatorSetDeregistered
- handles AllocationManager deregistrationgetCurrentOperatorSetIds
- retrieves current operator set IDsgetQuorumWeight
- calculates quorum weightgetOperatorSetWeight
- calculates operator set weightoperatorRegisteredOnAVSDirectory
- checks M2 quorum registrationoperatorRegisteredOnCurrentOperatorSets
- checks operator set registrationoperatorRegistered
- checks either registration typedisableM2QuorumRegistration
- disables new M2 registrationsupdateOperatorSetsConfig
- updates operator set strategy parametersECDSAAVSRegistrar
registerOperator
- handles operator registrationderegisterOperator
- handles operator deregistrationsupportsAVS
- checks AVS supportECDSAServiceManagerBase
deregisterOperatorFromOperatorSets
addPendingAdmin
removePendingAdmin
removeAdmin
setAppointee
removeAppointee
getOperatorSetStrategies
- retrieves strategies for an operator setNew Implementations
ECDSAStakeRegistryRatioWeight
with configurable weight ratiosECDSAStakeRegistryPermissioned
with new ejection logicTest Updates
Updated existing test files:
ECDSAStakeRegistryUnit.t.sol
ECDSAStakeRegistryPermissionedUnit.t.sol
ECDSAStakeRegistryEqualWeightUnit.t.sol
ECDSAServiceManager.t.sol
Added new test file:
ECDSAStakeRegistryRatioWeightUnit.t.sol
- tests for configurable weight ratios between M2 quorum and operator setsResult:
The refactored ECDSAStakeRegistry now supports both operator sets and legacy M2 quorum registrations, providing a robust dual-registration system. This enables backward compatibility and allows for future deprecation of M2 quorum registration.