Added '?' command to check the current Pokemon as terminal background for iTerm #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork
…current background Pokemon
samuelhnrq
reviewed
Oct 6, 2017
There was a problem hiding this comment.
The gist of it is great, but this clearly conflicts with #94 I could accept it now, but I would only end up overwriting it with the incoming command engine rework, if you could wait for it to be merged and then adapt the code would be much more constructive.
| Get the number of the background image of the terminal. | ||
| :rtype str | ||
| """ | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
Yes, clever, was thinking of doing exactly like this. But instead of exception, print a error message and quit so you don't have to do all these stub methods in the other implementations.
|
By the way would love some to have some Mac OS testing in #94 |
|
I would gladly wait until #94 gets merged, so I'll update this pull request when that happens. And I'll test it on Mac OS during the week! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I added the '?' command back (with 'current' as an alternative), but it currently only supports iTerm.
This was referenced in issue #38 , and works by checking the current background image path (if the path has '/', I assume a Pokemon has been set as background) of the instance of a terminal (solving the reason why #48 was rejected, since it works on a per instance basis).
If no Pokemon was set, it returns 'None'; if one was set, it returns the name, capitalized.
My only problem was checking what to assert in the test, and I ended up just checking that the result was a string.