feat(issue-116): add shared validation helpers#135
Merged
Ibinola merged 1 commit intoLead-Studios:mainfrom Mar 28, 2026
Merged
Conversation
|
@mxllv Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a small shared validation module so token-core and escrow paths can reuse the same checks for metadata inputs, amount semantics, ledger expiration boundaries, and frozen-account guards.
Changes
src/validation.rswith shared helpers for non-empty strings, decimal bounds, positive/non-negative amounts, expiration-ledger validation, and frozen-account checksmetadata.rsto use the shared metadata validation helpersallowance.rsto use shared checks for non-negative allowance amounts and current-or-future expiration ledgerscontract.rs,balance.rs, andescrow.rsto use shared positive-amount and frozen-account validation where those checks were duplicated or missingveritixpay/contract/token/src/lib.rs,veritixpay/contract/token/src/validation.rs,veritixpay/contract/token/src/metadata.rs,veritixpay/contract/token/src/allowance.rs,veritixpay/contract/token/src/balance.rs,veritixpay/contract/token/src/escrow.rs,veritixpay/contract/token/src/contract.rsValidation
cd veritixpay/contract/token && cargo +stable buildcd veritixpay/contract/token && cargo +stable test19 passed, 16 ignored)Mismatch Handling (if applicable)
validation.rsmodule and the direct call-site updates needed in token-core and escrow pathsNotes
approvecontinues to allow0as a revoke path, while negative allowances are now rejected through the shared helperCloses #116