feat: add GET /reports endpoint — list previously generated reports w…#171
Merged
BigBen-7 merged 1 commit intoLead-Studios:mainfrom Mar 27, 2026
Merged
Conversation
|
@Kaylahray Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ith download links
BigBen-7
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add GET /reports endpoint — list previously generated reports with download links
Closes #152
What changed
generated_reportsPostgres table — created on startup viaCREATE TABLE IF NOT EXISTS; backfilled from thereports/directory for any pre-existing files.POST /generate-daily-report— now inserts a metadata row (filename,report_date,format,size_bytes,generated_at) intogenerated_reportsafter writing each file.GET /reports(ADMIN) — returns up to 100 most-recent reports withdownload_urlfor each entry.GET /reports/download/{filename}(ADMIN) — streams the file as aFileResponse; validates filename against a strict allow-list pattern to prevent path traversal.src/types_custom.py— addedReportItemandReportsListResponsePydantic models.tests/test_reports_list.py— 20+ tests covering empty list, multiple reports, DB error handling, CSV/JSON download, 404, path-traversal rejection, and auth enforcement.Checklist
generated_reportstable with Postgres-backed metadataGET /reportscapped at 100 most recent, ADMIN-gatedGET /reports/download/{filename}streams file, ADMIN-gated