-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bevy 0.15.0 #664
Upgrade to Bevy 0.15.0 #664
Conversation
Most of the work here was fallout from the gamepads-as-entities change (bevyengine/bevy#12770), as well as the `PartialReflect` changes. This relies on bevyengine/bevy#15685. That PR must be applied to Bevy for this to build. The most recent upstream commit is 4bf647ff3b0ca7c8ca47496db9cfe03702328473.
…ager into 0.15-newer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You all rock. This looks great. I'll prepare a release!
Just found a merge hiccup and I fixed that, but I couldn't fix the broken gamepad tests... It's either something I messed up during the merge process, or it could be that some of the latest changes in |
Can you ignore the tests for now? I think we should move forward as is and then fix the tests in follow-up. |
Sure @alice-i-cecile, although I'm a bit worried since they seem to be checking the press status and the values of gamepad buttons and are failing to do so:
I tried fixing pcwalton's branch prior to merging main and the system ordering suggestion fixed all test issues, which suggests there's some other new issue that popped up for gamepads. I'll push a change to ignore them anyway if that's the way to go. |
Definitely share your concern: it's a blocking issue. I want to split it out though to be sure we can properly review and discuss the fix. |
I forgot to test this with all features enabled 😓 I'll do another pass and fix the remaining failures as soon as I can. |
Head branch was pushed to by a user without write access
@alice-i-cecile should be ready now, I ran all CI commands locally and they all pass. I took the liberty to adjust some doc comments to better fit the fact that Gamepads are now entities. |
Adopts #644
main
branch.bevy_egui
version requirement to the latest compatible version.SpriteBundle
withSprite
andTransform
components.