Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce boxed methods for insertion. #669

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CoolSlimbo
Copy link

PR introduces additional methods that allow using boxed versions of the traits directly.
Previous methods have been adapted to use the boxed versions underlying, and the boxed methods run all the (previous) logic to them.

Relevant issue: #620

@alice-i-cecile
Copy link
Contributor

Once you add a note to RELEASE.md I'll merge this in :) Thanks!

I think this is a bit clearer / less messy than impl Trait for Box<dyn Trait>.

@CoolSlimbo
Copy link
Author

Finalizing release notes now (suspecting this would be under 0.16.1 as a minor push?), was thinking, should this be listed in the readme as a feature? Especially since it's prime use case is allowing serialized types to be imputed?

@alice-i-cecile
Copy link
Contributor

Once we have a full test / example for serialization, yes please to putting it in the README. Until then, we shouldn't make promises that aren't tested :) Please feel free to add anything else required to fix #620: this is a feature I actively want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants