[WIP]: Handle user ID when creating and updating ticket via API #3086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ]; | ||
|
|
||
| if (! $this->projectService->isUserAssignedToProject(session('userdata.id'), $values['projectId'])) { | ||
| if (! $this->projectService->isUserAssignedToProject($userId, $values['projectId'])) { |
There was a problem hiding this comment.
The problem with this approach is that is completely circumvents the roles, permissions and projects assigned to an API Key. Devs could just set the userId to any administrator and act on behalf of that admin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested fix for #3085.
As mentioned in #3067 (comment) (and in #3068) some cleanups should be done throughout the code handling API requests.
Link to ticket
#3085
Type
Screenshot of the result
If your change affects the user interface, you should include a screenshot of the result with the pull request.