Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

286 - Adds skills folder to repo and loads markdown for each skill #349

Closed
wants to merge 15 commits into from
Closed

286 - Adds skills folder to repo and loads markdown for each skill #349

wants to merge 15 commits into from

Conversation

EmmaEm
Copy link

@EmmaEm EmmaEm commented Sep 28, 2017

Fixes #286
Previous PRs: #302 and #336

Overview

  1. Create new bin meta-helper for generating folders and initial file markdowns (not useful anymore, keeping until told otherwise)
  2. Include styling for skills markdown view
  3. Modify skills view file itself
  4. Modify skills route to use 'renderMarkdownFileToHTML' helper
  5. Add new markdownFileToHTML helper

lumodon and others added 15 commits September 28, 2017 13:51
@lumodon @Maighdlyn
Modifies helpers to prepare for skill markdowns
7160468 
Includes bin/skillsPopulate file left-over from old specs - no longer
useful but keeping until told to remove
@Maighdlyn
Modified skills related files(digest, views, and route)
dbd273f 
Modified skillsPopulate script
Removed accidental skills-markdown.js
@Maighdlyn
Added styling for individual pages
5d44ae2
@lumodon @Maighdlyn
Abstracts original function to DRY up our changes
5b5846c
@lumodon @Maighdlyn
Updates usage to be more explicit
368429a
@lumodon @Maighdlyn
Modifies rename-skills function to also change skill markdowns
b519ca8
@lumodon @Maighdlyn
Fixes last minute mistakes
d07e40e
@Maighdlyn
Use util for converting raw text to name
683b928
@Maighdlyn
Rename renameSkillsWithinContainer to renameSkills
0c205b7
@Maighdlyn
Merge renameSkillsWithinMarkdown and renameSkillsWithinModule into re…
5b36503 
…nameSkill
@Maighdlyn
Add whitespace formatting to skill markdown files
0c338bd
@Maighdlyn
Removes linebreaks to revert grocery-queries readme to original forma…
291e497 
…tting
@Maighdlyn
Get rid of h1 & checkbox, make span a div
fa58356
@Maighdlyn
Remove markdownFilePath from skill object & update references accordi…
21881e6 
…ngly
@Maighdlyn
Remove extra arguments from renderMarkdownFile & renderMarkdown
e97c768 
Revert & update helper functions as per comment
@EmmaEm EmmaEm mentioned this pull request Sep 28, 2017
Open
@jaredatron
Copy link
Contributor

please rebase and squash these commits down to 1 or a few commits

jaredatron
jaredatron suggested changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@jaredatron jaredatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/LearnersGuild/curriculum/pull/349

@jaredatron jaredatron closed this Oct 2, 2017
@lumodon lumodon mentioned this pull request Oct 2, 2017
Open
@lumodon
Copy link

lumodon commented Oct 2, 2017

PR: #363 (Squashed version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredatron jaredatron jaredatron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaEm @jaredatron @lumodon @Maighdlyn