Ravencoin: fixed signing and added more chain functionality#197
Open
kralverde wants to merge 20 commits intoLedgerHQ:masterfrom
kralverde:rerevert_tests
Open
Ravencoin: fixed signing and added more chain functionality#197kralverde wants to merge 20 commits intoLedgerHQ:masterfrom kralverde:rerevert_tests
kralverde wants to merge 20 commits intoLedgerHQ:masterfrom
kralverde:rerevert_tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the signing for ravencoin addresses which was previously broken.
It also implements ravencoin assets which have been lacking in the hardware department for the past 2 years.
Please let me know if the changes to btchip_display_variables.h is frowned upon; I can easily implement a "best fit" for the 20 char limit.