Open
Conversation
…itcoin_testnet_legacy variants
…g ledger-app-database branch
iartemov-ledger
force-pushed
the
derive_master
branch
from
c6e4e8c to
7f39373
Compare
iartemov-ledger
changed the title
There was a problem hiding this comment.
Pull request overview
This PR implements key derivation hardening by restricting BIP-32 derivation paths for cryptocurrency apps to prevent unauthorized key access across different coins.
Changes:
- Restricts
HAVE_APPLICATION_FLAG_DERIVE_MASTERflag to only Bitcoin Legacy and Bitcoin Test Legacy apps - Adds BIP-44 path restrictions (
PATH_APP_LOAD_PARAMS) for each supported cryptocurrency - Updates the lib-app-bitcoin submodule to support the hardening changes
Reviewed changes
Copilot reviewed 4 out of 71 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib-app-bitcoin | Updates submodule commit to version supporting path hardening |
| Makefile | Adds path restrictions for all coins and limits master derivation flag to legacy Bitcoin apps |
| CHANGELOG.md | Documents the derivation path hardening changes |
| .github/workflows/guidelines_enforcer.yml | Updates workflow to use branch-specific guidelines enforcer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iartemov-ledger
force-pushed
the
derive_master
branch
from
7f39373 to
82d85c6
Compare
iartemov-ledger
changed the title
bboilot-ledger
approved these changes
Mar 6, 2026
bigspider
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
=> corresponds to the documentation from the product:
develop