Fix Name display

LedgerHQ · Mar 13, 2024 · 40a85fe · 40a85fe
1 parent b6305f8
commit 40a85fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/gpg_ux_nanos.c b/src/gpg_ux_nanos.c
@@ -1002,11 +1002,9 @@ const bagl_element_t *ui_menu_main_predisplay(const ux_menu_entry_t *entry,
         explicit_bzero(G_gpg_vstate.menu, sizeof(G_gpg_vstate.menu));
         if (element->component.userid == 0x21) {
             memmove(G_gpg_vstate.menu, (void *) (N_gpg_pstate->name.value), 12);
-            if (G_gpg_vstate.menu[0] == 0) {
-                strlcpy(G_gpg_vstate.menu, "<No Name>", 9);
-            } else {
+            if (G_gpg_vstate.menu[0] != 0) {
                 for (int i = 0; i < 12; i++) {
-                    if (G_gpg_vstate.menu[i] == '<') {
+                    if ((G_gpg_vstate.menu[i] == '<') || (G_gpg_vstate.menu[i] == '>')) {
                         G_gpg_vstate.menu[i] = ' ';
                     }
                 }

diff --git a/src/gpg_ux_nanox.c b/src/gpg_ux_nanox.c
@@ -1207,11 +1207,9 @@ UX_FLOW(ux_flow_main,
 void ui_menu_main_predisplay() {
     explicit_bzero(G_gpg_vstate.ux_buff1, sizeof(G_gpg_vstate.ux_buff1));
     memmove(G_gpg_vstate.ux_buff1, (void *) (N_gpg_pstate->name.value), 20);
-    if (G_gpg_vstate.ux_buff1[0] == 0) {
-        strlcpy(G_gpg_vstate.ux_buff1, "<No Name>", 9);
-    } else {
+    if (G_gpg_vstate.ux_buff1[0] != 0) {
         for (int i = 0; i < 12; i++) {
-            if (G_gpg_vstate.ux_buff1[i] == '<') {
+            if ((G_gpg_vstate.menu[i] == '<') || (G_gpg_vstate.menu[i] == '>')) {
                 G_gpg_vstate.ux_buff1[i] = ' ';
             }
         }

diff --git a/src/gpg_ux_nbgl.c b/src/gpg_ux_nbgl.c
@@ -96,7 +96,7 @@ void ui_init(void) {
     memmove(name, (void*) (N_gpg_pstate->name.value), 20);
     if (name[0] != 0) {
         for (int i = 0; i < 12; i++) {
-            if (name[i] == '<') {
+            if ((name[i] == '<') || (name[i] == '>')) {
                 name[i] = ' ';
             }
         }