fix nistp256 template

LedgerHQ · Feb 29, 2024 · 69532fd · 69532fd
1 parent 7205e9d
commit 69532fd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/gpg_ux_nanos.c b/src/gpg_ux_nanos.c
@@ -621,7 +621,7 @@ void ui_menu_tmpl_set_action(unsigned int value) {
                 attributes.value[0] = KEY_ID_ECDSA;
             }
             oid = gpg_curve2oid(G_gpg_vstate.ux_type, &oid_len);
-            memmove(attributes.value + 1, oid, sizeof(oid_len));
+            memmove(attributes.value + 1, oid, oid_len);
             attributes.length = 1 + oid_len;
             break;
 

diff --git a/src/gpg_ux_nanox.c b/src/gpg_ux_nanox.c
@@ -607,13 +607,16 @@ void ui_menu_tmpl_set_action(unsigned int value) {
             break;
 
         case CX_CURVE_SECP256R1:
+            oid = gpg_curve2oid(G_gpg_vstate.ux_type, &oid_len);
+            if (oid == NULL) {
+                break;
+            }
             if (G_gpg_vstate.ux_key == 2) {
                 attributes.value[0] = KEY_ID_ECDH;
             } else {
                 attributes.value[0] = KEY_ID_ECDSA;
             }
-            oid = gpg_curve2oid(G_gpg_vstate.ux_type, &oid_len);
-            memmove(attributes.value + 1, oid, sizeof(oid_len));
+            memmove(attributes.value + 1, oid, oid_len);
             attributes.length = 1 + oid_len;
             break;