Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curves #102

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Fix curves #102

merged 4 commits into from
Mar 14, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

Fix curves usage:

  • Revert previous commit on buffer lengths checks because it impacts other curves
  • Add secp256k1 in the menus
  • Update snapshots accordingly

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 14, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.01%. Comparing base (cd08b73) to head (dc6b525).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #102   +/-   ##
========================================
  Coverage    27.01%   27.01%           
========================================
  Files            1        1           
  Lines          211      211           
========================================
  Hits            57       57           
  Misses         154      154           
Flag Coverage Δ
unittests 27.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedelavergne-ledger cedelavergne-ledger merged commit 400ff19 into develop Mar 14, 2024
40 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/fix_curves branch August 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants