Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cv25519 decrypt function #103

Closed
wants to merge 1 commit into from

Conversation

cedelavergne-ledger
Copy link
Contributor

1st step to fix cv25519 decryption.
Now the code doesn't return CX_INVALID_CURVE anymore.

Remaining an issue show on the PC side:

gpg: public key is 551E384EA3608B44
gpg: no running gpg-agent - starting '/usr/bin/gpg-agent'
gpg: waiting for the agent to come up ... (5s)
gpg: connection to agent established
gpg: using subkey 551E384EA3608B44 instead of primary key BA8BF32C7557C015
gpg: pinentry launched (46842 gnome3 1.1.1 /dev/pts/2 xterm-256color :0 20620/1000/5 1000/1000 -)
gpg: ecdh failed in gcry_cipher_decrypt: Checksum error
gpg: using subkey 551E384EA3608B44 instead of primary key BA8BF32C7557C015
gpg: encrypted with 255-bit ECDH key, ID 551E384EA3608B44, created 2024-03-15
      "testkey"
gpg: public key decryption failed: Checksum error
gpg: decryption failed: No secret key
Decryption error!

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 15, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.01%. Comparing base (400ff19) to head (db129e4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #103   +/-   ##
========================================
  Coverage    27.01%   27.01%           
========================================
  Files            1        1           
  Lines          211      211           
========================================
  Hits            57       57           
  Misses         154      154           
Flag Coverage Δ
unittests 27.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/gpg_pso.c Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants