Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 101: Improve doc readability #104

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Mar 21, 2024

Update code readability:

  • Add inline comment for functions description
  • Minor code optimization to ease readability
    • Remove useless parameter for ui_info
    • Remove useless functions gpg_init_ux and io_seproxyhal_display
    • Add constant definition
    • Unique function app_reset instead of duplicate code
  • Replace multiple if by switch/case
  • Update version to 2.2.2
  • Fix pytools ECC key attribute name

This fixes #101

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

- Remove useless parameter for 'ui_info'
- Remove useless functions 'gpg_init_ux' and 'io_seproxyhal_display'
- Add constant definition
- Unique function 'app_reset' instead of duplicate code
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.01%. Comparing base (400ff19) to head (2ec0a05).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #104   +/-   ##
========================================
  Coverage    27.01%   27.01%           
========================================
  Files            1        1           
  Lines          211      211           
========================================
  Hits            57       57           
  Misses         154      154           
Flag Coverage Δ
unittests 27.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedelavergne-ledger cedelavergne-ledger merged commit 4f84034 into develop Mar 21, 2024
40 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/issue_101_doc branch August 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation to be improved
3 participants