✨ (signer-solana) [DSDK-564]: Add solana SignDataTask and utils #459
+540
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fAnselmi-Ledger
force-pushed
the
feat/DSDK-564-ts-signer-sol-create-sign-data-task
branch
from
754f2e7
to
c89aaa7
Compare
aussedatlo
reviewed
Oct 30, 2024
packages/signer/signer-solana/src/internal/app-binder/task/SendCommandInChunksTask.ts
Outdated
Show resolved
Hide resolved
packages/signer/signer-solana/src/internal/app-binder/task/SignDataTask.ts
Outdated
Show resolved
Hide resolved
fAnselmi-Ledger
force-pushed
the
feat/DSDK-564-ts-signer-sol-create-sign-data-task
branch
from
c89aaa7
to
1889537
Compare
fAnselmi-Ledger
force-pushed
the
feat/DSDK-564-ts-signer-sol-create-sign-data-task
branch
from
1889537
to
aeb921d
Compare
aussedatlo
reviewed
Oct 31, 2024
| }; | ||
|
|
||
| export type CommandFactory<T> = < | ||
| V extends ChunkableCommandArgs & Record<string, Uint8Array>, |
There was a problem hiding this comment.
[SHOULD] Remove & Record<string, Uint8Array> as it's not needed
| commandFactory: CommandFactory<T>; | ||
| }; | ||
|
|
||
| export class SignDataTask<Uint8Array> { |
There was a problem hiding this comment.
[COULD] Use Signature model instead of UInt8Array
|
|
||
| return await new SendCommandInChunksTask<Uint8Array>(this.api, { | ||
| data: buffer, | ||
| commandFactory: (args) => commandFactory(args), |
There was a problem hiding this comment.
[COULD] you can use directly
return await new SendCommandInChunksTask<Uint8Array>(this.api, {
data: buffer,
commandFactory,
}).run();
fAnselmi-Ledger
force-pushed
the
feat/DSDK-564-ts-signer-sol-create-sign-data-task
branch
from
aeb921d
to
c1c881d
Compare
aussedatlo
approved these changes
Nov 4, 2024
fAnselmi-Ledger
force-pushed
the
feat/DSDK-564-ts-signer-sol-create-sign-data-task
branch
from
c1c881d
to
35706ec
Compare
fAnselmi-Ledger
deleted the
feat/DSDK-564-ts-signer-sol-create-sign-data-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add solana SignDataTask and utils
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers