Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Elrond ESDT tokens & EGLD staking integration #1585

Open
wants to merge 174 commits into
base: develop
Choose a base branch
from

Conversation

AlexandruPislariu
Copy link
Contributor

Context (issues, jira)

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 18, 2022 at 6:10AM (UTC)

Copy link
Contributor

@henri-ly henri-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Good job !

@@ -95,6 +95,11 @@ const envDefinitions = {
def: "https://elrond.coin.ledger.com",
desc: "Elrond API url",
},
ELROND_DELEGATION_API_ENDPOINT: {
parser: stringParser,
def: "https://delegation-api.elrond.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need a ledger proxy for this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants