Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LL-8531 Fix Bitcoin RBF logic #1826

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

LL-8531 Fix Bitcoin RBF logic #1826

wants to merge 8 commits into from

Conversation

hzheng-ledger
Copy link
Contributor

@hzheng-ledger hzheng-ledger commented Mar 23, 2022 •
edited
Loading

@hzheng-ledger hzheng-ledger requested a review from a team as a code owner March 23, 2022 09:21
@vercel
Copy link

vercel bot commented Mar 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/3Qn33NW1A8BB43wTvTLou1KKLVq6
✅ Preview: https://ledger-live-common-git-bitcoin-js-rbf-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #1826 (c42b9ee) into develop (76e3f11) will decrease coverage by 10.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           develop    #1826       +/-   ##
============================================
- Coverage    69.74%   59.71%   -10.03%     
============================================
  Files          545      545               
  Lines        23507    23507               
  Branches      6185     6183        -2     
============================================
- Hits         16394    14038     -2356     
- Misses        7070     9450     +2380     
+ Partials        43       19       -24
Impacted Files Coverage Δ
src/families/bitcoin/bridge/mock.ts 89.36% <ø> (ø)
src/families/bitcoin/datasets/bitcoin.ts 100.00% <ø> (ø)
src/families/bitcoin/datasets/digibyte.ts 100.00% <ø> (ø)
src/families/bitcoin/datasets/litecoin.ts 100.00% <ø> (ø)
src/families/bitcoin/js-buildTransaction.ts 95.65% <ø> (ø)
src/families/bitcoin/js-createTransaction.ts 100.00% <ø> (ø)
src/families/bitcoin/js-estimateMaxSpendable.ts 100.00% <ø> (ø)
src/families/bitcoin/specs.ts 93.70% <ø> (+3.93%) ⬆️
src/families/bitcoin/types.ts 100.00% <ø> (ø)
src/families/bitcoin/cache.ts 88.46% <100.00%> (-0.43%) ⬇️
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3f11...c42b9ee. Read the comment docs.

@hzheng-ledger hzheng-ledger changed the title [WIP]fix rbf logic fix rbf logic Mar 28, 2022
ghost
ghost approved these changes Mar 28, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghost
Copy link

ghost commented Mar 28, 2022

A couple errors on Peercoin in the bot results, @hzheng-ledger what do you think, can it be related?

@hzheng-ledger
LL-1589 more robust bitcoin retry (#1835)
c0e9695 
* fix bot

* fix sync error exception process
@vercel
Copy link

vercel bot commented Apr 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 26, 2022 at 4:09PM (UTC)

@hzheng-ledger hzheng-ledger marked this pull request as draft April 26, 2022 16:48
@ghost ghost changed the title fix rbf logic LL-8531 Fix Bitcoin RBF logic Apr 28, 2022
@hzheng-ledger hzheng-ledger mentioned this pull request Jun 7, 2022
Closed
3 tasks
@hzheng-ledger hzheng-ledger mentioned this pull request Jun 28, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hzheng-ledger