This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Update live-common #1808
Merged
Update live-common #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valpinkman
previously approved these changes
Jul 12, 2021
|
Hey there, upon trying to build this PR on Android, I ran into a syntax error in node_modules/pdkdf, let me know if you need additional details, can't provide a screenshot here @gre |
|
ok i think i had it one once, but i had it fixed by running with node 14 |
|
thanks! we are on it. |
valpinkman
previously approved these changes
Jul 13, 2021
|
Hey guys, Ran into something dirty while performing regression testing. Steps to reproduce :
|
ychen-ledger
suggested changes
Jul 13, 2021
We introduced a bug when tracking analytics, can't rely on account.currency when sub-accounts are possible.
valpinkman
previously approved these changes
Jul 13, 2021
Merged
ghost
pushed a commit
to hzheng-ledger/ledger-live-mobile
that referenced
this pull request
Oct 13, 2021
* Update live-common * live-common 20.3.0 * latest url for zerion * fix * update latest platform wording * update dep * fix pbkdf2 error * Fix crash on op details swap history We introduced a bug when tracking analytics, can't rely on account.currency when sub-accounts are possible. * Use name, not id for tracking event * Actually pass the account down to the footer Co-authored-by: Valentin D. Pinkman <[email protected]> Co-authored-by: Juan Cortes Ross <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ledgerhq.atlassian.net/browse/LL-6308
https://github.com/LedgerHQ/ledger-live-common/releases/tag/v20.2.0
https://github.com/LedgerHQ/ledger-live-common/releases/tag/v20.3.0
see LedgerHQ/ledger-live-desktop#3962 for impact of the scope