Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”§(ios) update build targets config #8376

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 15, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

This PR solves a problem that prevented us from launching a staging version locally.
We can refer to this thread : react-native-community/cli#2383

Context:

In the case someone wants to test a staging build in local we need to ensure that the build can be launched on simulator / real device.

Problem:

When we run pnpm mobile ios:staging the build is well done but there is an Exception and the app won't open on the device
image

The issue is related to the build target of xcodescheme that focused React instead of Mobile. This is because there is multiple target and by default it will select the first target

image

Solution:

As suggested in the github thread we can remove the React target so xcode targets Mobile. This way the app is correctly build and launch using pnpm mobile ios:staging

image

I've not the exact reason of this but it might be related to the fact that React is link to our project because of react-native

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner November 15, 2024 13:33
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:33pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:33pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:33pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:33pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 15, 2024
@LucasWerey LucasWerey changed the title ::wrench:(ios) update build targets config πŸ”§(ios) update build targets config Nov 15, 2024
@LucasWerey LucasWerey merged commit 8165e1b into develop Nov 15, 2024
54 of 61 checks passed
@LucasWerey LucasWerey deleted the chore/xscheme branch November 15, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants