Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current PR branch when compiling C SDK #805

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Oct 17, 2024

Description

When compiling the Rust SDK, use the PR branch of the C SDK (and not the master branch as it will not test the PR modifications).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (5fe1622) to head (bcbc22c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   35.76%   35.76%           
=======================================
  Files          13       13           
  Lines        1591     1591           
=======================================
  Hits          569      569           
  Misses       1022     1022           
Flag Coverage Δ
unittests 35.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yogh333 yogh333 merged commit 67320f0 into master Oct 17, 2024
182 of 184 checks passed
@yogh333 yogh333 deleted the y333_241017/fix_rustsdk_ci branch October 17, 2024 08:45
abonnaudet-ledger pushed a commit that referenced this pull request Oct 21, 2024
Use current PR branch when compiling C SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants