WIP fixed missing thead...

LeeWannacott · May 29, 2023 · 2909d8a · 2909d8a
1 parent e354eb5
commit 2909d8a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/public/index.html b/public/index.html
@@ -89,9 +89,8 @@ <h2>Testing table containing colspan and data-sort and multiple tbodies</h2>
           <th colspan="2" class="data-sort">On Our Dates</th>
           <th>First Sold Out</th>
         </tr>
-      </thead>
-      <tbody>
         <tr>
+      </thead>
           <td class="tags"></td>
           <td class="category">Comedy</td>
           <td class="show_name">Show 1</td>
@@ -161,7 +160,6 @@ <h2>Testing table containing colspan and data-sort and multiple tbodies</h2>
           <td class="pct ours">50%</td>
           <td>2022-07-31</td>
         </tr>
-      </tbody>
       <thead>
         <tr>
           <th>Last Name</th>
@@ -174,7 +172,7 @@ <h2>Testing table containing colspan and data-sort and multiple tbodies</h2>
           <th class="data-sort">data-sort days</th>
           <th>dates in dd/mm/yyyy</th>
         </tr>
-      </thead>
+</thead>
       <tr class="table-row-1">
         <td>Franklin</td>
         <td>Benjamin</td>
@@ -230,6 +228,7 @@ <h2>Testing table containing colspan and data-sort and multiple tbodies</h2>
         <td data-sort="1">Monday</td>
         <td>8/6/1978</td>
       </tr>
+      </tbody>
       <thead>
         <tr>
           <th>Last Name</th>
@@ -242,7 +241,7 @@ <h2>Testing table containing colspan and data-sort and multiple tbodies</h2>
           <th class="data-sort">data-sort days</th>
           <th>dates in dd/mm/yyyy</th>
         </tr>
-      </thead>
+        </thead>
       <tr class="table-row-1">
         <td>Franklin</td>
         <td>Benjamin</td>

diff --git a/public/table-sort.js b/public/table-sort.js
@@ -49,8 +49,8 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
     if (sortableTable.getElementsByTagName("thead").length === 0) {
       createMissingTableHead(sortableTable);
       if (sortableTable.querySelectorAll("tbody").length > 1) {
-        // Why index 1?; I don't remember
-        return sortableTable.querySelectorAll("tbody")[1];
+        // don't select empty tbody that the browser creates
+        return sortableTable.querySelectorAll('tbody:not(:nth-child(2))');
       } else {
         return sortableTable.querySelectorAll("tbody");
       }