Fix for if table.body is null which it could be because browser exten…

…sion applies table-sort to all tables.
LeeWannacott · May 21, 2023 · 71cfe1e · 71cfe1e
1 parent 084f9f1
commit 71cfe1e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/public/table-sort.js b/public/table-sort.js
@@ -55,6 +55,7 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
         return sortableTable.querySelector("tbody");
       }
     } else {
+      // if <tr> or <td> exists below <thead> the browser will make <tbody>
       return sortableTable.querySelector("tbody");
     }
   }
@@ -111,6 +112,7 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
       body: getTableBody(sortableTable),
       head: sortableTable.querySelector("thead"),
     };
+    if(table.body == null){ return }
     table.headers = table.head.querySelectorAll("th");
     table.rows = table.body.querySelectorAll("tr");
 

diff --git a/test/missingTableTags.test.js b/test/missingTableTags.test.js
@@ -13,7 +13,7 @@ test("test no missing table tags - (user has put <tbody> and <thead>)", () => {
   ).toStrictEqual(["Alpha", "Bravo", "Charlie", "Delta", "Echo"]);
 });
 
-test("test with missing <tbody> tag - (tbody and thead exist)", () => {
+test("test with missing <tbody> tag - thead exist", () => {
   expect(
     createTestTableMissingBodyTag([
       "Echo",
@@ -37,7 +37,7 @@ test("test with missing <thead> tag)", () => {
   ).toStrictEqual(["Alpha", "Bravo", "Charlie", "Delta", "Echo"]);
 });
 
-test("test with missing <tbody> and <thead> tags - (tbody and thead exist)", () => {
+test("test with missing <tbody> and <thead> tags", () => {
   expect(
     createTestTableMissingBodyAndHeadTag([
       "Echo",