Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsDelivr links. #100

Closed
LeeWannacott opened this issue May 21, 2023 · 7 comments
Closed

Update jsDelivr links. #100

LeeWannacott opened this issue May 21, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@LeeWannacott
Copy link
Owner

LeeWannacott commented May 21, 2023

https://cdn.jsdelivr.net/npm/table-sort-js@latest/table-sort.js doesn't seem to show latest version where as https://cdn.jsdelivr.net/npm/table-sort-js@1/table-sort.js seems to actually show the latest released version. Might as well update to this; don't expect to be v2 anytime soon anyway...

update readme and docs links

@LeeWannacott LeeWannacott added the good first issue Good for newcomers label May 21, 2023
@Cioraz
Copy link
Contributor

Cioraz commented May 21, 2023

Hello, I am interested in contributing could you assign me the issue?

@LeeWannacott
Copy link
Owner Author

LeeWannacott commented May 21, 2023

@Cioraz Sure thing you are assigned the issue! (if you could research @latest vs 1 and what it does that might be handy; it doesn't work how I thought it would... I guess because it gets cached, or something...). I thought it would just give you the latest release?

@LeeWannacott
Copy link
Owner Author

LeeWannacott commented May 21, 2023

Made a related good first issue for adding another example: using script tag from cdn/jsDelivr: #105

@Cioraz
Copy link
Contributor

Cioraz commented May 21, 2023

@Cioraz Sure thing you are assigned the issue! (if you could research @latest vs 1 and what it does that might be handy; it doesn't work how I thought it would... I guess because it gets cached, or something...). I thought it would just give you the latest release?

Hello, I found that when @latest is added, it get cached for 24hrs. So even with new releases within that period, it would still show the same previous version.
Also this is not recommended for production usage as requesting latest usually come with breaking changes which may break the codeflow.

However without the @latest, it loads the newest version immediately whose caching period is 1 week.

Reference : https://stackoverflow.com/questions/69148904/difference-in-jsdelivr-url-with-without-latest

@LeeWannacott
Copy link
Owner Author

@Cioraz Sure thing you are assigned the issue! (if you could research @latest vs 1 and what it does that might be handy; it doesn't work how I thought it would... I guess because it gets cached, or something...). I thought it would just give you the latest release?

Hello, I found that when @latest is added, it get cached for 24hrs. So even with new releases within that period, it would still show the same previous version. Also this is not recommended for production usage as requesting latest usually come with breaking changes which may break the codeflow.

However without the @latest, it loads the newest version immediately whose caching period is 1 week.

Reference : https://stackoverflow.com/questions/69148904/difference-in-jsdelivr-url-with-without-latest

Okay cool, I think @1 should be good.

@LeeWannacott
Copy link
Owner Author

LeeWannacott commented May 21, 2023

@Cioraz Sorry, After thinking about this maybe we can just do https://cdn.jsdelivr.net/npm/table-sort-js/table-sort.js and https://cdn.jsdelivr.net/npm/table-sort-js/table-sort.min.js we don't need @1. Should be less confusing to users who are like what does @1 mean.

@LeeWannacott
Copy link
Owner Author

Done in PR: #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants