Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Links and Updated ReadMe #106

Closed
wants to merge 3 commits into from
Closed

Modified Links and Updated ReadMe #106

wants to merge 3 commits into from

Conversation

Cioraz
Copy link
Contributor

@Cioraz Cioraz commented May 21, 2023

Changes to the Links and Readme. #100

@LeeWannacott
Copy link
Owner

Looks good; the new minified links aren't minified there is also https://github.com/LeeWannacott/table-sort-js/blob/master/public/docs/html5.html#LL71C1-L71C1 . Which is this page: https://leewannacott.github.io/table-sort-js/docs/html5.html

@LeeWannacott
Copy link
Owner

LeeWannacott commented May 21, 2023

Hey @Cioraz , After thinking about this more I don't think we need to do @1 we could just do https://cdn.jsdelivr.net/npm/table-sort-js/table-sort.js and https://cdn.jsdelivr.net/npm/table-sort-js/table-sort.min.js for the minified version; I think this is less confusing. @Cioraz Sorry for the inconvenience; would you be able to change the links to these instead?

@Cioraz
Copy link
Contributor Author

Cioraz commented May 21, 2023

Sure I'll change them

@LeeWannacott
Copy link
Owner

LeeWannacott commented May 21, 2023

@Cioraz This latest commit looks good, the second commit is changing a bunch of stuff that doesn't need to be changed. You could run git revert 36f97c957d2dc90d1ce9cbf17519ca559f7f3617 to undo the second commit. This will make a new commit thats reverts the second commit and then you would push this revert commit to the branch and it should get rid of the unnecessary changes in the second commit. I think this should work let me know if it doesn't.

@Cioraz
Copy link
Contributor Author

Cioraz commented May 21, 2023

Hey, im running into a few errors doing what you stated above. Could I create another pull request with only these changes ?

@LeeWannacott
Copy link
Owner

LeeWannacott commented May 21, 2023

Hey, im running into a few errors doing what you stated above. Could I create another pull request with only these changes ?

Sure, no worries.

@LeeWannacott
Copy link
Owner

Done in PR #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants