Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and optimize #86

Merged
merged 9 commits into from
May 14, 2023
Merged

Refactor and optimize #86

merged 9 commits into from
May 14, 2023

Conversation

LeeWannacott
Copy link
Owner

@LeeWannacott LeeWannacott commented May 13, 2023

stragers big O video: https://www.youtube.com/watch?v=7VHG6Y2QmtM&t=1s

If 50% of the column doesn't have a regex match we break; if 50% of the column has matches and applied a class we break; .

We also removed an outer loop of the inferSortClasses() function by moving it into the loop that makes each column sortable which is great because if the inferSortClasses() function has a critical failure the column wont become sortable (which improves performance even more)!

I refactored this probably about 5 times trying different approaches sadly I didn't commit them all which could of been interesting to see the different approaches. I settled on this...

Probably a completely premature optimization; that would only effect really massive tables...

Comment on lines 95 to 108
if (Object.values(matches).every((match) => match === null)) {
regexNotFoundCount++;
continue;
}
for (let key of Object.keys(inferableClasses)) {
if (matches[key] !== null) {
inferableClasses[key].count++;
}
if (isoDatesMatch) {
isoDatesCounter++;
if (inferableClasses[key].count >= threshold) {
th.classList.add(inferableClasses[key].class);
classNameAdded = true;
break;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Object.values(matches).every((match) => match === null)) {
regexNotFoundCount++;
continue;
}
for (let key of Object.keys(inferableClasses)) {
if (matches[key] !== null) {
inferableClasses[key].count++;
}
if (isoDatesMatch) {
isoDatesCounter++;
if (inferableClasses[key].count >= threshold) {
th.classList.add(inferableClasses[key].class);
classNameAdded = true;
break;
}
}
let foundMatch = false;
for (let key of Object.keys(inferableClasses)) {
let classRegexp = inferableClasses[key].regexp;
if (tableColumn.innerText.match(classRegexp) !== null) {
foundMatch = true;
inferableClasses[key].count++;
}
if (inferableClasses[key].count >= threshold) {
th.classList.add(inferableClasses[key].class);
classNameAdded = true;
break;
}
}
if (!foundMatch) {
regexNotFoundCount++;
continue;
}

@LeeWannacott LeeWannacott merged commit efba045 into master May 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants