Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings 3 #98

Merged
merged 10 commits into from
May 21, 2023
Merged

Refactorings 3 #98

merged 10 commits into from
May 21, 2023

Commits on May 20, 2023

  1. Move dataattributes function out of make column sortable

    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    4bcdd16 View commit details
    Browse the repository at this point in the history

  2. Move sortfilezize, sortdates, sortruntime out of makecolumnsortable s… 

    …o not defined multiple times.
    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    148c1f9 View commit details
    Browse the repository at this point in the history

  3. Move getTableData out of make each column sortable.

    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    b376028 View commit details
    Browse the repository at this point in the history

  4. Move updateTable out of makeeachcolumn sortable.

    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    49274ed View commit details
    Browse the repository at this point in the history

  5. Move getColumn function definition onto column object.

    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    c0ccedf View commit details
    Browse the repository at this point in the history

  6. Move updateTable stuff related to fileSize into its own function to b… 

    …e less confusing.
    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    6f27076 View commit details
    Browse the repository at this point in the history

  7. WIP: fix file-size-sort useing innerhtml.

    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    3c4b12b View commit details
    Browse the repository at this point in the history

  8. WIP 2: fix file-size-sort useing innerhtml.

    @LeeWannacott
    LeeWannacott committed May 20, 2023
    Configuration menu
    Copy the full SHA
    8701c00 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Fixed file-size-sort sorting cells rather than rows.

    @LeeWannacott
    LeeWannacott committed May 21, 2023
    Configuration menu
    Copy the full SHA
    783c27a View commit details
    Browse the repository at this point in the history

  2. Remove remember sort from declared for each column.

    @LeeWannacott
    LeeWannacott committed May 21, 2023
    Configuration menu
    Copy the full SHA
    e74f160 View commit details
    Browse the repository at this point in the history