-
Notifications
You must be signed in to change notification settings - Fork 1
[LNK-67] global common 코틀린 마이그레이션 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "refactor/LNK-67-Leenk-global-common-\uCF54\uD2C0\uB9B0-\uB9C8\uC774\uADF8\uB808\uC774\uC158"
Changes from all commits
11a4468
03f29f2
5808d2a
6dee780
1f03a72
ba619ba
5dcf1bc
72427bb
21c328f
7c31ce9
5699430
023da48
1c9186f
765b01c
dacd658
c0aa312
14eea48
127aaf4
cdcf2f3
f5ff38d
d7614be
064ce29
e376b90
d1b9f70
78f273e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| description: "코드 리뷰 에이전트를 활용해 현재까지의 작업을 리뷰합니다." | ||
| --- | ||
|
|
||
| # Code Review Command | ||
|
|
||
| Invoke the code review agent defined in `.claude/agents/code-review-agent.md` to perform code review. | ||
|
|
||
| ## Determine Review Target | ||
|
|
||
| 1. Check staged changes with `git diff --staged` | ||
| 2. If nothing staged, check current branch commit history with `git log` and review | ||
|
|
||
| ## Rules | ||
|
|
||
| - If agent file (`.claude/agents/code-review-agent.md`) doesn't exist, notify user and stop | ||
| - Follow the checklist and output format defined in the agent exactly | ||
|
|
||
|
|
||
| ## Changes | ||
|
|
||
| | Item | Reason | | ||
| |------|--------| | ||
| | Specify agent path | Claude needs exact file location to find it | | ||
| | Specific git commands | Clear instructions on how to check | | ||
| | Add "follow agent format" | Prevent ignoring agent file's output format | | ||
|
|
||
| ## Folder Structure | ||
|
|
||
| .claude/ | ||
| ├── commands/ | ||
| │ └── code-review.md # This command file | ||
| └── agents/ | ||
| └── code-review-agent.md # Agent definition (checklist, output format, etc.) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| description: "kotlin-migration-agent를 사용해 Java 파일을 코틀린으로 마이그레이션하는 명령어입니다." | ||
| --- | ||
|
|
||
| # Instructions | ||
|
|
||
| You MUST use the Task tool to invoke the kotlin-migration-agent immediately. | ||
|
|
||
| ## Input Processing | ||
|
|
||
| 1. If user provides a file path: | ||
| - Use Read tool to verify the file exists and is a Java file | ||
| - Pass the absolute file path to the agent | ||
|
|
||
| 2. If user provides a directory path: | ||
| - Use Glob to find all `.java` files in that directory | ||
| - Pass the directory path to the agent | ||
|
|
||
| 3. If no path provided: | ||
| - Ask user to specify the Java file or directory to migrate | ||
|
|
||
| ## Agent Invocation | ||
|
|
||
| Call the Task tool with: | ||
| - subagent_type: "kotlin-migration-agent" | ||
| - prompt: "Migrate [FILE_PATH or DIRECTORY_PATH] from Java to Kotlin following the Test-First methodology" | ||
| - description: "Migrate Java to Kotlin" | ||
|
|
||
| Example: | ||
| ```text | ||
| Task tool: | ||
| subagent_type: kotlin-migration-agent | ||
| prompt: Migrate src/main/java/leets/leenk/domain/feed/service/FeedGetService.java from Java to Kotlin following the Test-First methodology | ||
| description: Migrate Java to Kotlin | ||
| ``` | ||
|
|
||
| ## Important Notes | ||
|
|
||
| - NEVER perform migration yourself - ALWAYS delegate to kotlin-migration-agent | ||
| - Agent will handle: test writing, migration, refactoring, and ktlint verification | ||
| - Agent follows strict order: Test → Migrate → Refactor → Verify | ||
| - All agent output will be in Korean as per agent rules | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일명 오타 수정 필요
파일명이
kotlin-mirgrate.md로 되어 있는데, "migrate"의 철자가 틀렸습니다.kotlin-migrate.md로 변경해야 합니다. PR 설명에서 언급한/kotlin-migration명령어와의 일관성을 위해서도 정확한 철자 사용이 필요합니다.📝 파일명 변경 제안
파일명을 다음과 같이 변경하세요:
.claude/commands/kotlin-mirgrate.md.claude/commands/kotlin-migrate.md🤖 Prompt for AI Agents