Skip to content

Conversation

@jj0526
Copy link
Collaborator

@jj0526 jj0526 commented Nov 19, 2025

📌 PR 내용

  • Apple private key 경로 환경변수 적용

🔍 PR 세부사항

  • dev 환경에서 애플 client secret이 생성에 실패하는 문제가 있었습니다
    • 원인 : 기존 구현이 private key를 classpath에서만 읽도록 고정되어 있어 Docker 환경에서 .p8 파일을 찾지 못함
  • private key 경로를 APPLE_PRIVATE_KEY_PATH 환경변수 기반으로 읽도록 수정

📸 관련 스크린샷


📝 주의사항


✅ 체크리스트

  • 리뷰어 설정
  • Assignee 설정
  • Label 설정
  • 제목 양식 맞췄나요? (ex. [WTH-01] PR 템플릿 수정)
  • 변경 사항에 대한 테스트

Summary by CodeRabbit

릴리스 노트

  • Chores
    • Apple 인증 설정을 개선했습니다. 개인 키 경로 설정이 환경 변수 기반으로 변경되어 배포 환경별 설정 관리가 더욱 유연해졌습니다.

@jj0526 jj0526 self-assigned this Nov 19, 2025
@jj0526 jj0526 added the fix label Nov 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Apple 프라이빗 키 경로가 하드코딩된 파일명 AuthKey_5JL5Z7K6J7.p8에서 환경 변수 기반 변수 ${APPLE_PRIVATE_KEY_PATH}로 변경되었습니다. auth.providers.apple 설정 아래에서만 수정되었으며, 다른 구조적 또는 동작상 변화는 없습니다.

Changes

Cohort / File(s) Change Summary
Apple 인증 설정 외부화
src/main/resources/application.yml
Apple 프라이빗 키 경로를 환경 변수로 외부화 (AuthKey_5JL5Z7K6J7.p8${APPLE_PRIVATE_KEY_PATH})

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3분

Poem

🐰 설정이 환경변수로 춤을 춘다,
하드코딩의 올가미에서 해방되고,
Apple 키는 이제 숨을 쉰다,
보안의 미소로, 더 안전하게! 🔐✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/WTH-73-Weeth-apple-private-key-경로-환경변수-적용

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc6a85d and d00c4c4.

📒 Files selected for processing (1)
  • src/main/resources/application.yml (1 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jj0526 jj0526 merged commit fe91d61 into develop Nov 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants