[1주차] 한하람/[feat] 프로젝트 초기 설정 및 기초 API 구현#11
Merged
Hanharam merged 14 commits intoLeets-Official:한하람/mainfrom Mar 27, 2026
Hidden character warning
The head ref may contain hidden characters: "\ud55c\ud558\ub78c/1\uc8fc\ucc28"
Merged
[1주차] 한하람/[feat] 프로젝트 초기 설정 및 기초 API 구현#11Hanharam merged 14 commits intoLeets-Official:한하람/mainfrom
Hanharam merged 14 commits intoLeets-Official:한하람/mainfrom
Conversation
8 tasks
Comment on lines
+25
to
+26
| INVALID_ENV(HttpStatus.BAD_REQUEST, "ENV-001", "현재 실행 환경에서는 사용할 수 없는 기능입니다.") | ||
| ; |
hanharam/src/main/java/com/leets/blog/repeat/controller/RepeatControllerDocs.java
Outdated
Show resolved
Hide resolved
hanharam/src/main/java/com/leets/blog/repeat/dto/request/RepeatRequest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+7
to
+8
| @Service | ||
| @RequiredArgsConstructor |
There was a problem hiding this comment.
지금은 Test단계라 괜찮지만 추후에 CommandService(생성,수정,삭제) 는 트랜잭션을 추가하는게 좋아보입니다!
QueryService(조회) 일때는 트랙잭션(readOnly) 로 추가하는것도 동시성 문제에 도움이 될 것 같습니다!
Comment on lines
+36
to
+40
| log.trace("TRACE"); | ||
| log.debug("DEBUG"); | ||
| log.info("INFO"); | ||
| log.warn("WARN"); | ||
| log.error("ERROR"); |
jihoonkim501
approved these changes
Mar 24, 2026
jihoonkim501
left a comment
jihoonkim501
left a comment
There was a problem hiding this comment.
하람님 도메인별로 상태코드, 예외처리 세부적으로 잘 나누신 것 같습니다! 수고 많으셨습니다! 제가 남긴 코멘트 몇개만 참고해주시면 좋을 것 같습니다!
gusanans218
approved these changes
Mar 25, 2026
hanharam/src/main/java/com/leets/blog/global/exception/constant/CommonErrorCode.java
Outdated
Show resolved
Hide resolved
N-yujeong
approved these changes
Mar 26, 2026
N-yujeong
left a comment
N-yujeong
left a comment
There was a problem hiding this comment.
👍 전체적으로 과제 요구사항을 잘 반영하여 구현하신 것 같습니다.
추가적으로 validation과 공통 응답 구조까지 함께 구현하신 점도 좋았습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 과제 요구사항 중 구현한 내용
GET /health)POST /string/repeat)2. 핵심 변경 사항
공통 응답 래핑
ApiResponse클래스 생성하여{success, code, message, result}Api 응답 규격 설정ResponseBodyAdvice를 구현한GlobalResponseWrapper를 통해 컨트롤러의 반환값을 자동으로ApiResponse를 반환하도록 자동화전역 예외 처리
GlobalExceptionHandler를 구현하여 전역에서 발생하는 예외를 한 곳에서 처리BusinessException기반의 예외 구조 설계 및CommonErrorCode세팅repeat, test구현
RepeatRequestDTO에record& @Valid 어노테이션 사용RepeatResponse정적 팩토리 메서드 사용3. 실행 및 검증 결과
GET /health응답:POST /string/repeat요청/응답:성공
예외
4. 완료 사항
5. 추가 사항
제출 체크리스트
{이름}/main브랜치다{이름}/{숫자}주차브랜치다Reviewer 참고