Skip to content

fix #91 파일 저장 버그 수정 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jj0526 merged 1 commit into from
Aug 6, 2025
Merged

fix #91 파일 저장 버그 수정 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/leets/bookmark/domain/file/application/usecase/FileUseCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void saveThumbnailFile(User user, Bookmark bookmark, String thumbnailUrl)
String fileName = extractFileNameWithExtension(thumbnailUrl);
FileType type = getValidatedFileType(fileName);

String s3UrlResponse = s3UploadService.upload(thumbnailUrl);
String s3UrlResponse = s3UploadService.upload(thumbnailUrl, type);

File file = fileMapper.toThumbnailFile(user, bookmark, fileName, s3UrlResponse, type);
fileSaveService.save(file);
Expand Down Expand Up @@ -86,7 +86,7 @@ public void updateThumbnailImage(User user, Bookmark bookmark, String thumbnailU
String fileName = extractFileNameWithExtension(thumbnailUrl);
FileType type = getValidatedFileType(fileName);

String s3UrlResponse = s3UploadService.upload(thumbnailUrl);
String s3UrlResponse = s3UploadService.upload(thumbnailUrl, type);

fileUpdateService.updateThumbnailImage(file, fileName, s3UrlResponse, type);
}
Expand Down
11 changes: 6 additions & 5 deletions src/main/java/leets/bookmark/domain/file/domain/service/S3UploadService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package leets.bookmark.domain.file.domain.service;

import leets.bookmark.domain.file.application.exception.S3UploadException;
import leets.bookmark.domain.file.domain.entity.enums.FileType;
import lombok.RequiredArgsConstructor;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.stereotype.Service;
Expand Down Expand Up @@ -28,15 +29,15 @@ public class S3UploadService {

private static final DateTimeFormatter FORMATTER = DateTimeFormatter.ofPattern("yyyyMMddHHmmss");

public String upload(String fileUrl) {
public String upload(String fileUrl, FileType fileType) {
try {
URL url = URI.create(fileUrl).toURL();
HttpURLConnection connection = (HttpURLConnection) url.openConnection();
connection.setRequestMethod("GET");

try (InputStream inputStream = connection.getInputStream()) {

String fileName = generateUrl(fileUrl);
String fileName = generateUrl(fileType);

PutObjectRequest putObjectRequest = PutObjectRequest.builder()
.bucket(bucket)
Expand All @@ -54,8 +55,8 @@ public String upload(String fileUrl) {
}
}

private String generateUrl(String fileName) {
String extension = fileName.substring(fileName.lastIndexOf(".") + 1);
return LocalDateTime.now().format(FORMATTER) + UUID.randomUUID().toString() + "." + extension;
private String generateUrl(FileType fileType) {
String extension = fileType.getExtension();
return LocalDateTime.now().format(FORMATTER) + UUID.randomUUID().toString() + extension;
}
}