-
Notifications
You must be signed in to change notification settings - Fork 1
feat 97 메모 수정기능 추가 #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "feat/#97/\uBA54\uBAA8-\uC218\uC815\uAE30\uB2A5-\uCD94\uAC00"
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
daaf17e
feat: 수정할때 메모 수정 추가
katejhee 5e46b38
fix: 커스텀예외처리로 수정
katejhee cd0d55a
fix: 알림 수정 안되는것 수정
katejhee 4e58e44
Merge branch 'dev' into feat/#97/메모-수정기능-추가
katejhee 3834ec9
fix:enum 대문자로 수정
katejhee b115849
fix:매퍼로 수정
katejhee 5485865
Merge branch 'feat/#97/메모-수정기능-추가' of https://github.com/Leets-Offici…
katejhee e3951c1
fix: 매퍼 수정
katejhee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
...ets/bookmark/domain/bookmark/application/exception/BookmarkUpdateFieldEmptyException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package leets.bookmark.domain.bookmark.application.exception; | ||
|
|
||
| import leets.bookmark.global.common.exception.BusinessException; | ||
|
|
||
| public class BookmarkUpdateFieldEmptyException extends BusinessException { | ||
| public BookmarkUpdateFieldEmptyException() { | ||
| super(BookmarkErrorCode.BOOKMARK_UPDATE_FIELD_EMPTY_EXCEPTION); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thumbnailUrl,platform,faviconUrl,url은 모두url이 바뀌었기에 일어나기에 검증 처리를 통해 한번에 이루어져야 한다고 생각됩니다. 하지만 시간상 이후에 리팩토링으로 부탁드립니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵