Feat: 매칭 대기화면 전환 및 채팅방 참가 로직 추가 #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woneeeee
approved these changes
Feb 3, 2025
Member
woneeeee
left a comment
woneeeee
left a comment
There was a problem hiding this comment.
고생하셨습니다! 크게 리뷰달만한 부분이 없어보이네요...
| sse.onerror = () => { | ||
| console.error('SSE 에러 발생, 연결 종료 후 재연결 시도'); | ||
| console.error( | ||
| '🚨 SSE 연결 오류 발생! 연결을 종료하고 5초 후 재연결을 시도합니다.', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
채팅 대기화면에서 구독 메세지
topic에 따라 채팅방 참가 버튼 렌더링하는 로직 추가했습니다!지금 로딩이 어떻게 진행되고 있는지 잘몰라서 아직 빈값으로 두긴 했는데 일단 pr 올려두고 내일 회의하면서 로딩 관련 여쭤보고 머지할게요!
5. 추가 사항
해당 구독 객체 사용해서
isOwner판별하는 로직 메세지 객체 타입을 변경하면서 같이 수정했습니다!