[Feat] Checkbox 컴포넌트 개발 및 디자인 구현 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 검증 결과✅ TypeScript: 통과 |
PR 검증 결과✅ TypeScript: 통과 |
KyeongJooni
reviewed
Jan 11, 2026
src/shared/ui/Checkbox/Checkbox.tsx
Outdated
|
|
||
| return ( | ||
| <label className={root({ className })}> | ||
| <input type="checkbox" className="sr-only" checked={checked} disabled={disabled} {...props} /> |
Member
There was a problem hiding this comment.
Props 전개 순서를 바꿔야 할 것 같아요 {...props}가 마지막에 오면 명시적으로 전달한 checked, disabled 값을 제대로 인식 못할 수도 있을 것 같습니다!
Suggested change
| <input type="checkbox" className="sr-only" checked={checked} disabled={disabled} {...props} /> | |
| <input type="checkbox" className="sr-only" {...props} checked={checked} disabled={disabled} /> |
Collaborator
Author
There was a problem hiding this comment.
수정 했습니다. 커멘트 감사합니다.!
jwj0620gcu
changed the title
jwj0620gcu
changed the title
PR 검증 결과✅ TypeScript: 통과 |
PR 검증 결과✅ TypeScript: 통과 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 주요 변경사항
공통 Checkbox 컴포넌트를 신규 구현했습니다.
디자인 토큰(index.css)과 tailwind-variants 기반으로 피그마 스펙과 동일하게 스타일을 구성했습니다.
📝 작업 상세 내용
✅ 체크리스트
Close #번호추가📸 스크린샷 (선택)
🔍 기타 참고사항
🔗 관련 이슈