[3주차] 박소윤 / todolist 주요기능 구현 #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
이전에 올려주신 PR처럼 |
yezzan9
reviewed
Apr 8, 2025
src/App.css
Outdated
Comment on lines
51
to
60
| .add-button-container button { | ||
| width: 100%; | ||
| padding: 8px; | ||
| font-size: 1rem; | ||
| background-color: #000; | ||
| color: #fff; | ||
| border: none; | ||
| border-radius: 0; | ||
| cursor: pointer; | ||
| } |
Member
There was a problem hiding this comment.
테두리가 없어지지 않는 이유는 해당 부분때문인 것 같아요!
add-button-container에만 해당 설정이 지정되어야하는데, button이 추가되어서 모든 버튼 태그에 해당 css가 설정되었을 것 같아요!ㅠ,ㅠ
다른 설정같은 경우에는 덮어씌워져서 괜찮았을 텐데, delete버튼의 경우 따로 테두리 스타일링이 없으니 해당 스타일링이 나타난 것 같구요,,💦
여기서 button을 제거해주시면 해결될 것 같아요
One-HyeWon
requested changes
Apr 10, 2025
Member
One-HyeWon
left a comment
One-HyeWon
left a comment
There was a problem hiding this comment.
고생하셨습니다 소윤님!!
현재 base가 main으로 되어 있어서, 박소윤/main으로 변경 부탁드릴게요!!!!
꼭 변경 하신 후에 Merge 부탁드립니다
src/App.jsx
Outdated
| @@ -0,0 +1,80 @@ | |||
|
|
|||
src/App.jsx
Outdated
| editTask={editTask} | ||
| deleteTask={deleteTask} | ||
| activeTaskCount={activeTaskCount} | ||
| /> |
| @@ -0,0 +1,7 @@ | |||
|
|
|||
|
|
|||
| function CheckboxComponent({ isChecked, onChange }) { | |||
src/component/InputComponent.jsx
Outdated
Comment on lines
1
to
2
|
|
||
|
|
yezzan9
approved these changes
Apr 30, 2025
Member
yezzan9
left a comment
yezzan9
left a comment
There was a problem hiding this comment.
3주차 과제도 수고하셨습니다!
prettier 설정이 제대로 되어있지 않는 것 같아서 그 부분만 다시 확인해주시면 좋을 것 같아요!
src/App.jsx
Outdated
Comment on lines
51
to
57
| <TodoList | ||
| filteredTasks={filteredTasks} | ||
| toggleTask={toggleTask} | ||
| editTask={editTask} | ||
| deleteTask={deleteTask} | ||
| activeTaskCount={activeTaskCount} | ||
| /> |
Member
There was a problem hiding this comment.
들여쓰기가 제대로 안 되어있어요! prettier 설정이 안 되어있는 걸까요?🥺
src/component/InputComponent.jsx
Outdated
Comment on lines
1
to
2
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 작업 목적
2주차 작업에 추가적인 기능을 구현함
2. 작업 내용
delete버튼의 검정 테두리 없애기 (-->여러가지 수정해봤는데 구현이 안돼서 수정중에 있습니다..!)
작업 추가, 삭제, 완료, 상태별로 보기의 기능 구현
3. 스크린샷