[4주차] 박소윤/ todolist 추가기능 구현 #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezzan9
reviewed
Apr 30, 2025
Member
yezzan9
left a comment
yezzan9
left a comment
There was a problem hiding this comment.
4주차 과제도 수고하셨습니다!
코멘트 남겨드렸으니 확인하시고 소윤님 생각도 남겨주세용
Comment on lines
-6
to
+9
| <TextComponent text="TodoMatic" type="title" /> | ||
| <TextComponent text="What needs to be done?" type="subTitle" /> | ||
| <h1> | ||
| TodoMatic | ||
| </h1> | ||
| <h2 style={{ fontWeight: "normal" }}> | ||
| What needs to be done? | ||
| </h2> |
Member
There was a problem hiding this comment.
이 부분은 왜 TextComponent를 사용하지 않는 방식으로 수정하셨는지 궁금해용!
Comment on lines
+83
to
+98
| <> | ||
| <div className="task-row"> | ||
| <CheckboxComponent | ||
| isChecked={task.completed} | ||
| onChange={() => toggleTask(task.id)} // task.id 전달 | ||
| /> | ||
| <span className={`task-name ${task.completed ? 'completed' : ''}`}> {/* 완료된 할 일에 스타일 적용 */} | ||
| <TextComponent text={task.name} /> | ||
| </span> | ||
| </div> | ||
| <div className="task-actions"> | ||
| {/* Edit 클릭 시 handleEditClick 호출 */} | ||
| <ButtonComponent label="Edit" onClick={() => handleEditClick(task)} /> {/* task 객체 전체 전달 */} | ||
| <ButtonComponent label="Delete" onClick={() => deleteTask(task.id)} /> {/* task.id 전달 */} | ||
| </div> | ||
| </> |
Member
There was a problem hiding this comment.
TodoComponent를 삭제하고 인라인으로 구현해주셨는데, 기존에 구현하셨던 대로 TodoComponent를 이용해주셔야합니다! 해당 부분을 컴포넌트화하도록 수정해주세요🙌
Author
There was a problem hiding this comment.
앗 이거 두개 파일은 완전초반에 과제한건데 같이 올라온거같아요ㅜ! 삭제하겠습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 작업 목적
주요 기능 추가 마무리
2. 작업 내용
edit 할때 new name for, cancle, save 창으로 바뀌게 화면 전환
save버튼 검정색
task 스토리지에 저장하기
3. 구현