[5주차] 강태이/로그인 및 회원가입 UI 구현 #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezzan9
reviewed
May 7, 2025
Member
yezzan9
left a comment
yezzan9
left a comment
There was a problem hiding this comment.
5주차 과제도 수고하셨습니다!
전체적으로 잘 구현해주셨네요🙌 다만, prettier 설정이 계속 안 되어있는 것 같아 해당 부분만 확인해주시면 좋을 것 같아요!
Comment on lines
33
to
56
| const AddTodo = ({ onAddTodo }) => { | ||
| const [inputValue, setInputValue] = useState(""); | ||
|
|
||
| const handleInputChange = (e) => { | ||
| setInputValue(e.target.value); | ||
| }; | ||
|
|
||
| const handleAddClick = () => { | ||
| onAddTodo(inputValue); | ||
| setInputValue(""); | ||
| }; | ||
|
|
||
| return( | ||
| <AddTodoContainer> | ||
| <StyledText>What needs to be done?</StyledText> | ||
| <StyledInput type="text" placeholder="Add a task" /> | ||
| <StyledButton>Add</StyledButton> | ||
| <StyledInput | ||
| type="text" | ||
| placeholder="Add a task" | ||
| value={inputValue} | ||
| onChange={handleInputChange} | ||
| /> | ||
| <StyledButton onClick={handleAddClick}>Add</StyledButton> | ||
| </AddTodoContainer> | ||
| ) |
Comment on lines
+34
to
+43
| const styles = { | ||
| container: { | ||
| backgroundColor: "#f0f0f0", | ||
| height: "100vh", | ||
| display: "flex", | ||
| flexDirection: "column", | ||
| justifyContent: "center", | ||
| alignItems: "center", | ||
| fontFamily: "sans-serif", | ||
| }, |
Member
There was a problem hiding this comment.
styled component가 아니라 이런 식으로 구현하신 이유가 궁금해용 !!
Member
|
그리고 base branch가 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무엇을?
2. 스크린샷