Skip to content

Conversation

@soo0711
Copy link
Contributor

@soo0711 soo0711 commented Aug 2, 2025

📌 작업한 내용

  • 유저 닉네임 중복확인 기능을 구현했습니다.
  • 유저 회원가입시 선호하는 장르 선택 최대 3개까지 가능하게 했습니다.

🔍 참고 사항

  • 중복일 때는 true, 사용 가능 할 때는 false입니다.

🖼️ 스크린샷

  • 중복
스크린샷 2025-08-03 001751
  • 사용 가능
image

🔗 관련 이슈

#90

✅ 체크리스트

  • 로컬에서 빌드 및 테스트 완료
  • 코드 리뷰 반영 완료
  • 문서화 필요 여부 확인

@soo0711 soo0711 requested review from RokChoi and doup2001 August 2, 2025 15:21
@soo0711 soo0711 self-assigned this Aug 2, 2025
@soo0711 soo0711 added ✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링 labels Aug 2, 2025
@soo0711 soo0711 linked an issue Aug 2, 2025 that may be closed by this pull request
2 tasks
@github-actions
Copy link

github-actions bot commented Aug 2, 2025

Test Coverage Report

File Coverage [76.65%] 🍏
UserService.java 83.33% 🍏
UserController.java 54.72% 🍏
Total Project Coverage 52.93% 🍏

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

Test Results

107 tests  ±0   107 ✅ ±0   9s ⏱️ ±0s
 49 suites ±0     0 💤 ±0 
 49 files   ±0     0 ❌ ±0 

Results for commit b032d2a. ± Comparison against base commit c8d46c7.

♻️ This comment has been updated with latest results.

Copy link
Member

@doup2001 doup2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 중복됐다고 표시하는걸 200 ok와 responseDTO로 표시하는 것보다는, 예외를 던져서 처리하는게 맞다고 생각하는데 혹시 어떻게 생각하실까요?! 👀

@github-actions
Copy link

github-actions bot commented Aug 3, 2025

Test Coverage Report

File Coverage [72.2%] 🍏
UserService.java 77.13% 🍏
UserController.java 54.72% 🍏
Total Project Coverage 52.94% 🍏

Copy link
Member

@doup2001 doup2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외처리로 바뀌니까 더 깔끔해진것 같습니다 👍

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Test Coverage Report

File Coverage [72.2%] 🍏
UserService.java 77.13% 🍏
UserController.java 54.72% 🍏
Total Project Coverage 52.94% 🍏

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Test Coverage Report

File Coverage [72.2%] 🍏
UserService.java 77.13% 🍏
UserController.java 54.72% 🍏
Total Project Coverage 53.02% 🍏

@doup2001 doup2001 merged commit 96970e2 into develop Aug 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️refactor: 장르 max개수 수정 및 유저 닉네임 중복 확인 구현

3 participants