-
Notifications
You must be signed in to change notification settings - Fork 1
[feat] 프로필 수정 api 연결 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "feat/#65/\uD504\uB85C\uD544\uC218\uC815-api-\uC5F0\uACB0"
Conversation
src/api/user/userEdit.api.ts
Outdated
| const res = await api.put('/api/v1/profile', data); | ||
| return res.data.data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git pull origin develop 하시고 이 부분 '/profile'로 바꿔주셔야 할 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~😄 시간이 부족해서 빠르게 구현하고 싶은 마음은 충분히 이해댑니다..!!
다만 스웨거랑 피그마를 조금 더 꼼꼼히 보시고, 요구사항에 맞춰 작성해주셔야 할 것 같아요 ㅠㅠ
파이팅입니당
src/api/user/userEdit.api.ts
Outdated
| export const updateUserProfile = async ( | ||
| data: UpdateUserProfileRequest | ||
| ): Promise<UserProfileResponse> => { | ||
| const res = await api.put('/api/v1/profile', data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/api/profile/profile.api.ts
Outdated
|
|
||
| export const getUserProfile = async (): Promise<UserProfile> => { | ||
| try { | ||
| const response = await api.get<UserProfile>('/profile'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApiResponse 타입을 활용하면 좋을 것 같습니당
src/pages/my/ProfileEdit.tsx
Outdated
| showToast('프로필이 저장되었습니다.', 3000); | ||
| navigate('/my'); | ||
| } catch (error) { | ||
| showToast('저장에 실패했습니다.', 3000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 맞춰서 다른부분들도 변경하도록하겠습니다!
dalzzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 병합이 잘못된 것 같은데,, 한번 다시 확인 부탁드립니다..!
…into feat/#65/프로필수정-api-연결
…cial/SEEAT-FE into feat/#65/프로필수정-api-연결
…cial/SEEAT-FE into feat/#65/프로필수정-api-연결


🔍 관련된 이슈
📝 작업 내용
📸 스크린샷
🚨 이슈
이유는 모르겠으나.. s3이미지 업로드 관련 올려주신 pr이 전체pull이나 pr지정 pull해도 이미 업데이트됐는데
vscode에 나타나지않아서 파일 그대로 복붙한거라 무시해주셔도 됩니당...
📣 리뷰 요구사항
✅ 체크리스트