-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: 초대장 생성/상세조회 요청, 응답 DTO 수정 및 초대장 엔티티 추가 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a14fed8
refactor: 초대장 생성 ResponseDTO 수정 및 관련 테스트 코드 수정
1winhyun c9403fa
refactor: 컨벤션 유지
1winhyun 1db428d
refactor: templateKey 추가 및 초대장 생성 요청DTO에 해당 값 추가
1winhyun c159d01
refactor: 초대장 상세조회 반환 값 templateKey 추가
1winhyun 44d3d92
refactor: invitationEntity templateKey null값 초기화 부분 삭제
1winhyun 68644fa
refactor: 초대장 상세 조회 Reponse값에 ownerNickname 추가
1winhyun 5c93007
refactor: 메서드명 수정
1winhyun 625abf2
refactor: 메서드명 수정
1winhyun 7c975a2
refactor: 초대장 생성 반환값 수정
1winhyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ class InvitationServiceTest : DescribeSpec({ | |
| lateinit var nickname: String | ||
| lateinit var email: String | ||
| lateinit var qrUrl: String | ||
| lateinit var templateKey: String | ||
| lateinit var member: Member | ||
| var deleted = false | ||
|
|
||
|
|
@@ -36,6 +37,7 @@ class InvitationServiceTest : DescribeSpec({ | |
| nickname = "seunghyun" | ||
| email = "[email protected]" | ||
| qrUrl = "http://example.com" | ||
| templateKey = "templateKey" | ||
| deleted = false | ||
|
|
||
| member = Member( | ||
|
|
@@ -63,6 +65,7 @@ class InvitationServiceTest : DescribeSpec({ | |
| id = invitationId, | ||
| member = member, | ||
| qrUrl = qrUrl, | ||
| templateKey = templateKey, | ||
| deleted = deleted, | ||
| createdAt = LocalDateTime.now(), | ||
| modifiedAt = LocalDateTime.now() | ||
|
|
@@ -101,13 +104,14 @@ class InvitationServiceTest : DescribeSpec({ | |
| id = invitationId, | ||
| member = member, | ||
| qrUrl = qrUrl, | ||
| templateKey = templateKey, | ||
| deleted = deleted, | ||
| createdAt = LocalDateTime.now(), | ||
| modifiedAt = LocalDateTime.now() | ||
| ) | ||
| every { invitationPersistencePort.save(any<InvitationVO>()) } returns savedInvitation | ||
|
|
||
| val result = invitationService.createInvitation(memberId, qrUrl) | ||
| val result = invitationService.createInvitation(memberId, qrUrl, templateKey) | ||
|
|
||
| result shouldBe savedInvitation | ||
|
|
||
|
|
@@ -127,6 +131,7 @@ class InvitationServiceTest : DescribeSpec({ | |
| id = invitationId, | ||
| member = member, | ||
| qrUrl = qrUrl, | ||
| templateKey = templateKey, | ||
| deleted = deleted, | ||
| createdAt = LocalDateTime.now(), | ||
| modifiedAt = LocalDateTime.now() | ||
|
|
@@ -163,6 +168,7 @@ class InvitationServiceTest : DescribeSpec({ | |
| id = invitationId, | ||
| member = member, | ||
| qrUrl = qrUrl, | ||
| templateKey = templateKey, | ||
| deleted = false, | ||
| createdAt = LocalDateTime.now(), | ||
| modifiedAt = LocalDateTime.now() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.