refactor: 참석 여부 응답 API 수정 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Test Results66 tests 66 ✅ 2s ⏱️ Results for commit d675a29. ♻️ This comment has been updated with latest results. |
1winhyun
reviewed
Feb 3, 2025
Member
1winhyun
left a comment
1winhyun
left a comment
There was a problem hiding this comment.
수고하셨습니다!! attendance와 관련하여 리뷰 남겼습니다. 확인한번 부탁드립니다!!
...le-infrastructure/persistence-db/src/main/kotlin/site/yourevents/guest/entity/GuestEntity.kt
Show resolved
Hide resolved
yechan-kim
reviewed
Feb 3, 2025
module-domain/src/test/kotlin/site/yourevents/guest/service/GuestServiceTest.kt
Show resolved
Hide resolved
...structure/persistence-db/src/main/kotlin/site/yourevents/guest/repository/GuestRepository.kt
Show resolved
Hide resolved
...cture/persistence-db/src/test/kotlin/site/yourevents/guest/repository/GuestRepositoryTest.kt
Show resolved
Hide resolved
1winhyun
approved these changes
Feb 4, 2025
yechan-kim
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 유형
어떤 변경 사항이 있었나요?
✏️ 작업 내용
invitationId와memberId를 통해 조회하도록 변경하였습니다.guestId필드를 삭제, 그에 맞추어 파사드 및 서비스 클래스 또한 변경하였습니다.🔗 관련 이슈
💡 추가 사항
attendance필드를 nullable로 수정하였습니다.